Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xWaitForCluster: Enabled localization #139

Merged
merged 1 commit into from
Jul 28, 2017

Conversation

johlju
Copy link
Member

@johlju johlju commented Jul 27, 2017

Pull Request (PR) description

This Pull Request (PR) fixes the following issues:
Fixes #88

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

- Enabled localization for all strings (issue dsccommunity#88).
@msftclas
Copy link

@johlju,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@johlju johlju added the needs review The pull request needs a code review. label Jul 27, 2017
@codecov-io
Copy link

codecov-io commented Jul 27, 2017

Codecov Report

Merging #139 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #139   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         7      7           
  Lines       395    399    +4     
===================================
+ Hits        395    399    +4

@johlju
Copy link
Member Author

johlju commented Jul 27, 2017

@PlagueHO Do you mind reviewing this one too whenever you got a chance?

@PlagueHO
Copy link
Member

Can do! Getting it done now!

@PlagueHO
Copy link
Member

Can't find a single problem.

:lgtm:


Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju merged commit e6adc5f into dsccommunity:dev Jul 28, 2017
@joeyaiello joeyaiello removed the needs review The pull request needs a code review. label Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xWaitForCluster: Localization should change to align with HQRM modules
5 participants