Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xFailOverCluster: Opt-in for module files common tests #120

Merged
merged 1 commit into from
Jul 21, 2017

Conversation

johlju
Copy link
Member

@johlju johlju commented Jul 20, 2017

Pull Request (PR) description

This Pull Request (PR) fixes the following issues:
Fixes #119

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

- Opt-in for module files common tests (issue dsccommunity#119).
  - Removed Byte Order Mark (BOM) from the files; CommonResourceHelper.psm1 and FailoverClusters.stubs.psm1.
@msftclas
Copy link

@johlju,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@johlju johlju added the needs review The pull request needs a code review. label Jul 20, 2017
@johlju johlju requested a review from bgelens July 20, 2017 10:33
@codecov-io
Copy link

codecov-io commented Jul 20, 2017

Codecov Report

Merging #120 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff         @@
##           dev   #120   +/-   ##
==================================
  Coverage   90%    90%           
==================================
  Files        7      7           
  Lines      379    379           
==================================
  Hits       343    343           
  Misses      36     36

@johlju
Copy link
Member Author

johlju commented Jul 21, 2017

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju
Copy link
Member Author

johlju commented Jul 21, 2017

:LGTM:


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@johlju johlju merged commit 7730be3 into dsccommunity:dev Jul 21, 2017
@johlju johlju deleted the optin-module-files-common-tests branch July 27, 2017 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The pull request needs a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xFailOverCluster: Opt-in for module files common tests
3 participants