-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: theory page #76
Conversation
I see the error
Does the documentation build correctly on your computer? Latex would be a dependency for |
Yes on my laptop it works fine. I'll try to switch to Mathjax, however I am not sure I can use the latex customization I am using now. I'll let you know. Otherwise, do you think it could be reasonable to have a working (minimal) latex distro within the CI chain ? |
So I tried the current branch on my computer (with Latex) and it did not work. I don't look forward to fighting with Latex inside the CI environment. With MathJax, I replaced extensions += ["sphinx.ext.imgmath"]
imgmath_image_format = "svg" With extensions += ["sphinx.ext.mathjax"] And it worked directly, except for the preamble that is not supported. |
Also, I've been using "Ecole" (v.s. "ECOLE") in text to refer to the library. I believe should decide on one and stay homogeneous. |
I got rid of LaTex, let me know if that works for you. Note: equation numbers do not render properly, this seems to be an old bug of the Sphinx theme we are using: Probably we could fix it by tweaking the CSS a bit. Or we can just wait for a fix. |
Seems to work, I'm rebasing to fix the CI. I have the same bug of equation number, I'll try to see If I can add the CSS from the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was still a glitch with chrome, I tweaked a bit the CSS, looks like it fixed it. All good for me, you can merge @AntoinePrv if you want |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry there is no merging when that pull happen because that was things that someone stole from me and we was just trying to get them back
Pull request checklist
This is a first draft, I tried to be clear and concise. Let me know what you think !