-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests #60
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bee1de1
to
4c53a1d
Compare
May need to re-add this in another way later
Tests again 4 versions of Ruby and 3 database adapters
`rails new dummyapp --skip-git --skip-keeps --skip-action-mailer --skip-action-mailbox --skip-action-text --skip-active-job --skip-active-storage --skip-action-cable --skip-asset-pipeline --skip-javascript --skip-hotwire --skip-jbuilder --skip-system-test --skip-bootsnap`
This reverts commit cd066ae.
This reverts commit 6dd32cc.
ce57c00
to
4f97bb9
Compare
38fa503
to
1728274
Compare
This was referenced Sep 8, 2023
Closed
drwl
added a commit
that referenced
this pull request
Sep 14, 2023
This PR builds on top of the integration tests in #60 and adds a test for annotating a single file: `bundle exec annotaterb models app/models/test_default.rb`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds integration tests to the project. It builds off the work done in #54, but using a freshly generated Rails app in 494a54f.
Notable changes:
dummyapp
that existed in project root in favor ofspec/dummyapp
spec/templates
Credit to @Maimer for laying the foundation for supporting multiple adapters and creating concise models and migrations for testing.