Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests #60

Merged
merged 33 commits into from
Sep 8, 2023
Merged

Add integration tests #60

merged 33 commits into from
Sep 8, 2023

Conversation

drwl
Copy link
Owner

@drwl drwl commented Sep 7, 2023

This PR adds integration tests to the project. It builds off the work done in #54, but using a freshly generated Rails app in 494a54f.

Notable changes:

  • Deletes dummyapp that existed in project root in favor of spec/dummyapp
  • The source of truth for annotations from different database adapters are checked in, and can be found in spec/templates
  • Adds integration tests to CI

Credit to @Maimer for laying the foundation for supporting multiple adapters and creating concise models and migrations for testing.

@drwl drwl force-pushed the drwl/add-integration-tests branch from bee1de1 to 4c53a1d Compare September 7, 2023 22:04
Maimer and others added 25 commits September 7, 2023 19:32
May need to re-add this in another way later
Tests again 4 versions of Ruby and 3 database adapters
`rails new dummyapp --skip-git --skip-keeps --skip-action-mailer --skip-action-mailbox --skip-action-text --skip-active-job --skip-active-storage --skip-action-cable --skip-asset-pipeline --skip-javascript --skip-hotwire --skip-jbuilder --skip-system-test --skip-bootsnap`
@drwl drwl force-pushed the drwl/add-integration-tests branch from ce57c00 to 4f97bb9 Compare September 8, 2023 02:34
@drwl drwl force-pushed the drwl/add-integration-tests branch from 38fa503 to 1728274 Compare September 8, 2023 22:04
@drwl drwl merged commit 4e8257a into main Sep 8, 2023
@drwl drwl deleted the drwl/add-integration-tests branch September 8, 2023 22:35
drwl added a commit that referenced this pull request Sep 14, 2023
This PR builds on top of the integration tests in #60 and adds a test
for annotating a single file:

`bundle exec annotaterb models app/models/test_default.rb`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants