Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor model annotator #19

Merged
merged 73 commits into from
May 9, 2023
Merged

Refactor model annotator #19

merged 73 commits into from
May 9, 2023

Conversation

drwl
Copy link
Owner

@drwl drwl commented May 7, 2023 •
edited
Loading

  • Huge refactor of SchemaInfo for model annotator into separate classes
  • Fixes cases of can't modify frozen String: "bigint"
  • Fixes cases of no implicit conversion of nil into Array

drwl added 30 commits May 6, 2023 17:22
@drwl
Create ModelThing; Extract some column methods into it
2a267d7
@drwl
Extract #columns
bac0e15
@drwl
Check in ModelThing
30cf98a
@drwl
Move #width into Helper
6b467d0
@drwl
Extract #max_schema_info_width
96165d5
@drwl
Extract #get_schema_header_text
983caef
@drwl
Change method so to add back frozen string literal magic comment
6f23f14
@drwl
Tidy whitespace
365bf67
@drwl
Move #map_col_type_to_ruby_classes into Helper
be0dd94
@drwl
Move .quote into Helper
5ead066
@drwl
Move non_ascii_length, get_col_type into Helper
629cb48
@drwl
Create AnnotationGenerator; Move schema header into it
8b33753
@drwl
Make conditional blocks clearer
97e6408
@drwl
Attempt to expand conditional
6441dca
@drwl
Blockify more conditionals
0bf4123
@drwl
Move first conditional into ColumnThing
c907ce4
@drwl
Move more methods into ColumnThing
c7c1f3a
@drwl
Move array check, geometry, and geometric checks into ColumnThing
3ca2789
@drwl
Replace last usages of column in get_attributes
83641e2
@drwl
Move retrieve_indexes_from_table into ModelThing
c206fd0
@drwl
Remove duplicate with_comments? method from SchemaInfo
462f293
@drwl
Move schema footer method
459f5ae
@drwl
Move index helper methods out
e513df6
@drwl
Move mb_chars_ljust into Helper
23de386
@drwl
Blockify conditionals
be44aff
@drwl
Move get_attributes into ColumnThing
bc6f8fc
@drwl
Move klass into ColumnThing constructor
cc98921
@drwl
Move generate into AnnotationGenerator
289c26c
@drwl
Extract magic number constants
8c34e9f
@drwl
Remove get_ from methods
d1d18ff
drwl added 28 commits May 8, 2023 14:27
@drwl
Remove col_type arg from ColumnThing#get_attributes
8a9398c
@drwl
Inline #column_type
db3025c
@drwl
Change string append to string concatenate
fdcc44c
@drwl
Change string append to string concatenate
047b054
@drwl
Add comment about table_exists? check
3ecbb1e
@drwl
Rename ColumnThing => ColumnAnnotationBuilder
91ad31a
@drwl
Rename #get_attributes => #build
0edaf23
@drwl
Comment conditional
97fdd2f
@drwl
Change return type; Stop modifying string in place
66658ad
@drwl
Simplify conditional
1334646
@drwl
Separate column type and attributes logic
56c6172
@drwl
Join column type conditional
3bf4975
@drwl
Extract ColumnTypeBuilder
30b1eae
@drwl
Rename ColumnAnnotationBuilder => ColumnAttributesBuilder; Remove…
8c513f1 
… column type logic from it
@drwl
Tidy AnnotationGenerator#add_column_info
00fa727
@drwl
Extract column annotation building into own class
8301a20
@drwl
Extract index annotation building logic
3afba3d
@drwl
Extract foreign key annotation building
058c0bd
@drwl
Inline method
ac0d2bd
@drwl
Change string appends to string concatenation
2e3c786
@drwl
Replace instances of klass
63672d1
@drwl
Rename ModelThing => ModelWrapper
68c471a
@drwl
Convert #schema_footer_text to build string array
8eb2f41
@drwl
Remove SchemaInfo class
b88f53e
@drwl
Add tests for ColumnTypeBuilder
ea75872
@drwl
Add tests for ColumnAttributesBuilder
8ca985d
@drwl
Add tests for hide_limit_column_types option
55a4588
@drwl
Update instance of SchemaInfo
fd1ab6c
@drwl drwl merged commit 4fac6fa into main May 9, 2023
@drwl drwl deleted the drwl/refactor-model-annotator branch May 9, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@drwl