Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added two simple cube tokens #121

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Conversation

elmodor
Copy link
Contributor

@elmodor elmodor commented Nov 27, 2022

Fixes/Solves
There were no cube tokens present in the default asset pack. This serves two purposes:

  • Some default basic colored tokens (red and green). They can be used as counter, tracker, etc
  • As an example template for other cube tokens

The focus is of course more on the first bullet point: To have a marker/tracker without any number on it that can be used universally.

Size measured by some real cardboard cut out tokens.

Copy link
Owner

@drwhut drwhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

This seems like a good idea, but I've got two points:

  • Instead of having different images for each token, it's probably better to have one image for a "white" token, and allow the user to change the colour in-game - you can also add some preset token colours using the config file, see the dice configs as an example!
  • Unless you don't mind me being the "author" of the images, you can set the author and license of the images in the config file.

@elmodor
Copy link
Contributor Author

elmodor commented Nov 28, 2022

tokens

Done and done!

Copy link
Owner

@drwhut drwhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, just a couple more things that I've spotted!

  • If the image is just pure white, you can massively reduce the size of the image by having it be a 1x1 .bmp image!
  • The "A simple token." description is redundant, since it gets overwritten by all of the other descriptions in the file.

@elmodor
Copy link
Contributor Author

elmodor commented Nov 28, 2022

It's not completely pure white. I made the shade a tiny bit different. Would you rather like a pure white one?

Removed the redundant desc

@drwhut
Copy link
Owner

drwhut commented Nov 28, 2022

Ah sorry, I just assumed it was pure white. The original colour is fine! 🙂

@elmodor
Copy link
Contributor Author

elmodor commented Nov 29, 2022

Okay, let me know if there's anything else left to do 😄

@drwhut
Copy link
Owner

drwhut commented Nov 29, 2022

Apart from the simplifying of the image, we could also take the time to add a whole bunch of colours? We could use the dice as an example (and that way, we could get the tokens and dice to match colours?)

@elmodor
Copy link
Contributor Author

elmodor commented Nov 29, 2022

Will do.

Is there any place (in the repo or in the docs) where we could store UV template files?

@elmodor
Copy link
Contributor Author

elmodor commented Nov 29, 2022

White image is 1x1 bmp and added all the colors from the dices.

Copy link
Owner

@drwhut drwhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@drwhut
Copy link
Owner

drwhut commented Nov 29, 2022

Is there any place (in the repo or in the docs) where we could store UV template files?

There's already UV templates in the docs.

@elmodor
Copy link
Contributor Author

elmodor commented Nov 29, 2022

Turns out many games also need: cubes. Like little cubes:
Little cubes

How would you feel if I extended this MR to include not only tokens but also cubes?
Changing the name for the tokens to: White Token and the cubes would be White Cube

@drwhut
Copy link
Owner

drwhut commented Nov 30, 2022

I feel like the tokens should do for most use cases - can always open up another PR if there's demand for little cubes!

@drwhut drwhut merged commit 44a08e3 into drwhut:master Nov 30, 2022
@elmodor elmodor deleted the basic_cube_tokens branch November 30, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants