-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added two simple cube tokens #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
This seems like a good idea, but I've got two points:
- Instead of having different images for each token, it's probably better to have one image for a "white" token, and allow the user to change the colour in-game - you can also add some preset token colours using the config file, see the dice configs as an example!
- Unless you don't mind me being the "author" of the images, you can set the
author
andlicense
of the images in the config file.
b9d78bd
to
9ad88da
Compare
9ad88da
to
ef22d63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, just a couple more things that I've spotted!
- If the image is just pure white, you can massively reduce the size of the image by having it be a 1x1 .bmp image!
- The "A simple token." description is redundant, since it gets overwritten by all of the other descriptions in the file.
ef22d63
to
85758df
Compare
It's not completely pure white. I made the shade a tiny bit different. Would you rather like a pure white one? Removed the redundant desc |
Ah sorry, I just assumed it was pure white. The original colour is fine! 🙂 |
Okay, let me know if there's anything else left to do 😄 |
Apart from the simplifying of the image, we could also take the time to add a whole bunch of colours? We could use the dice as an example (and that way, we could get the tokens and dice to match colours?) |
Will do. Is there any place (in the repo or in the docs) where we could store UV template files? |
85758df
to
faf0bd4
Compare
faf0bd4
to
12d9081
Compare
White image is 1x1 bmp and added all the colors from the dices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There's already UV templates in the docs. |
Turns out many games also need: cubes. Like little cubes: How would you feel if I extended this MR to include not only tokens but also cubes? |
I feel like the tokens should do for most use cases - can always open up another PR if there's demand for little cubes! |
Fixes/Solves
There were no cube tokens present in the default asset pack. This serves two purposes:
The focus is of course more on the first bullet point: To have a marker/tracker without any number on it that can be used universally.
Size measured by some real cardboard cut out tokens.