Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vagrant transport to Drush. #4036

Merged
merged 3 commits into from
Apr 7, 2019

Conversation

alexxed
Copy link
Contributor

@alexxed alexxed commented Apr 6, 2019

This allows executing drush calls via vagrant ssh -c by just using vagrant: in the site alias file. Support for this was added in site-process here: consolidation/site-process#40

alexxed added 2 commits April 6, 2019 22:50
This allows executing drush calls via vagrant ssh -c by just using vagrant: in the site alias file. Support for this was added in site-process here: consolidation/site-process#40
@greg-1-anderson
Copy link
Member

Hm, we really should have had Drush call some Site Process API to add the default transports rather than wire it up manually via Dependency Injection.

This way fully specifies what our runtime class usage is, but it's kind of unfortunate to have to modify Drush for every new transport. Maybe there won't be many more, though.

This way is therefore okay, once it has passing tests.

@alexxed
Copy link
Contributor Author

alexxed commented Apr 7, 2019

Oh, if we use the new vagrant transport, we need to release site process so we can update composer.json here. Let me try your suggestion, that way we could move forward with this PR.

@greg-1-anderson
Copy link
Member

Yeah, this looks much better. I should have done it like this in the first place.

I'm leaving shortly for the airport (DrupalCon), but I'll tag a new release for site-process in the near future.

@greg-1-anderson greg-1-anderson merged commit 24027b3 into drush-ops:master Apr 7, 2019
m4olivei added a commit to m4olivei/drush that referenced this pull request May 24, 2019
* master:
  Remove latest unstable chiclet. Its not helpful.
  Remove mentions of Shippable. (drush-ops#4079)
  Add mysql service to Travis config. (drush-ops#4078)
  Fix link in docs.
  More docs about dynamic users in site.yml files.
  Fix drush-ops#4055. Sort inside namespaces in list command. (drush-ops#4057)
  Print class name in drush_op()
  Update dependencies. (drush-ops#4051)
  UNISH_NO_TIMEOUTS is unused since we moved to CLITrait. (drush-ops#4047)
  Add jsonapi command (drush-ops#4045)
  Fixes drush-ops#4034: Ensure that status code is nonzero on invalid shutdown (drush-ops#4037)
  Add webflo/drupal-core-require-dev (drush-ops#4041)
  Fix TTY detection for runserver command. (drush-ops#4033)
  Add vagrant transport to Drush. (drush-ops#4036)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants