Upsert conditions: fix post-upsert load when conditions no longer match #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verifies that the upsert option allows performing and update.
It is possible to use the upsert option to cause the document to no longer match the search condition. To retrieve the upserted document, look it up by its _id instead of querying the search conditions again.
binki
added a commit
to binki/mongoose-findorcreate
that referenced
this pull request
May 29, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using upsert, you might modify the entity so that it no longer matches the search conditions. The result is that the returned loaded object is
nullinstead of the loaded object. This change fixes that by loading the updated entity using_idinstead ofconditions.