Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pnpm install with v10 #497

Merged
merged 1 commit into from
Feb 21, 2025
Merged

fix: pnpm install with v10 #497

merged 1 commit into from
Feb 21, 2025

Conversation

sfroment
Copy link
Member

@sfroment sfroment commented Feb 20, 2025

Signed-off-by: Sacha Froment [email protected]

What type of PR is this?

  • Bug Fix

Description

When using pnpm10 you have to explicitly tell which module can run post install

Related Issues and PRs

  • Related: #
  • Closes: #

Added/updated tests?

  • No, because why: I don't think this is use full to build a whole pnpm 10 pipeline just for this, we can just start to use it as well instead

Additional Info

add instructions or screenshots on what you might think is relevant or instructions on how to manually test it

[optional] Do we need to perform any post-deployment tasks?

Copy link

github-actions bot commented Feb 20, 2025

Flamegraph.com report

flamegraph.pprof
See in flamegraph.com

Created by Flamegraph.com Github Action

@hoangquocvietuet hoangquocvietuet linked an issue Feb 21, 2025 that may be closed by this pull request
Signed-off-by: Sacha Froment <[email protected]>
Copy link
Contributor

@anhnd350309 anhnd350309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfroment sfroment merged commit 16e6316 into main Feb 21, 2025
14 checks passed
@sfroment sfroment deleted the fix/pnpm-10 branch February 21, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Bug when run the repo
2 participants