Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use types #495

Merged
merged 2 commits into from
Feb 24, 2025
Merged

refactor: use types #495

merged 2 commits into from
Feb 24, 2025

Conversation

sfroment
Copy link
Member

@sfroment sfroment commented Feb 19, 2025

What type of PR is this?

  • Refactor

Description

Related Issues and PRs

  • Related: #
  • Closes: #

Added/updated tests?

  • No, because why: it's refactor

Additional Info

add instructions or screenshots on what you might think is relevant or instructions on how to manually test it

[optional] Do we need to perform any post-deployment tasks?

Copy link

github-actions bot commented Feb 20, 2025

Flamegraph.com report

flamegraph.pprof
See in flamegraph.com

Created by Flamegraph.com Github Action

Copy link
Contributor

@anhnd350309 anhnd350309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfroment sfroment force-pushed the feat/correct-peerId branch 2 times, most recently from 24fb66d to 97bafc8 Compare February 21, 2025 14:39
Copy link
Member

@JanLewDev JanLewDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfroment sfroment force-pushed the feat/correct-peerId branch from 97bafc8 to 021bb53 Compare February 24, 2025 13:46
Copy link
Member

@trungnotchung trungnotchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfroment sfroment merged commit ec5b182 into main Feb 24, 2025
14 checks passed
@sfroment sfroment deleted the feat/correct-peerId branch February 24, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants