refactor: move peer id from drpObject to hashgraph #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamegraph.com reportCreated by Flamegraph.com Github Action |
anhnd350309
changed the title
anhnd350309
requested review from
JanLewDev,
trungnotchung,
winprn,
hoangquocvietuet and
magnified103
as code owners
winprn
reviewed
Feb 15, 2025
winprn
approved these changes
Feb 18, 2025
Signed-off-by: Sacha Froment <[email protected]>
sfroment
force-pushed
the
feat/correct-peerId
branch
from
2548e53 to
b2d76bf
Compare
sfroment
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR fixes the issue by moving
peerIdfromDRPObjecttohashGraph, ensuring proper vertex creation.Related Issues and PRs
Added/updated tests?
peerIdAdditional Info
[optional] Do we need to perform any post-deployment tasks?