Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unuse transport #466

Merged
merged 4 commits into from
Feb 17, 2025
Merged

refactor: remove unuse transport #466

merged 4 commits into from
Feb 17, 2025

Conversation

anhnd350309
Copy link
Contributor

@anhnd350309 anhnd350309 commented Feb 13, 2025 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Remove unused transport and ensure the protocol still work without them:

  • webRTCDirect
  • WebTransport

And remove unused function

Related Issues and PRs

Added/updated tests?

  • Yes
  • No, because why: just remove transport
  • I need help with writing tests

Additional Info

[optional] Do we need to perform any post-deployment tasks?

@anhnd350309 anhnd350309 marked this pull request as ready for review February 13, 2025 15:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

Flamegraph.com report

flamegraph.pprof
See in flamegraph.com

Created by Flamegraph.com Github Action

JanLewDev
JanLewDev approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@JanLewDev JanLewDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anhnd350309 anhnd350309 changed the title feat: remove unuse transport refactor: remove unuse transport Feb 17, 2025
@sfroment sfroment merged commit da00d10 into main Feb 17, 2025
14 checks passed
hoangquocvietuet pushed a commit that referenced this pull request Feb 18, 2025
@anhnd350309 @hoangquocvietuet
refactor: remove unuse transport (#466)
23abdfd
sfroment added a commit that referenced this pull request Feb 19, 2025
@sfroment
Merge remote-tracking branch 'origin/main' into fix/duplicate-drp-call
84e480f 
* origin/main:
  fix: dialTimeout (#484)
  fix: serialization & add types pkg (#472)
  feat: deterministic topo sort using iterative dfs (#471)
  refactor(object): linearize pair semantic (#476)
  refactor: remove unuse transport (#466)
  fix: pr template (#464)
sfroment added a commit that referenced this pull request Feb 19, 2025
@sfroment
Merge remote-tracking branch 'origin/main' into fix/duplicate-drp-call
48ef774 
* origin/main:
  fix: dialTimeout (#484)
  fix: serialization & add types pkg (#472)
  feat: deterministic topo sort using iterative dfs (#471)
  refactor(object): linearize pair semantic (#476)
  refactor: remove unuse transport (#466)
  fix: pr template (#464)

Signed-off-by: Sacha Froment <[email protected]>
@anhnd350309 anhnd350309 deleted the feat/remove-unused-transport branch February 20, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfroment sfroment sfroment left review comments

@JanLewDev JanLewDev JanLewDev approved these changes

@winprn winprn winprn approved these changes

@d-roak d-roak Awaiting requested review from d-roak d-roak is a code owner

@trungnotchung trungnotchung Awaiting requested review from trungnotchung trungnotchung is a code owner

@hoangquocvietuet hoangquocvietuet Awaiting requested review from hoangquocvietuet

@magnified103 magnified103 Awaiting requested review from magnified103 magnified103 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused transport
5 participants
@anhnd350309 @sfroment @JanLewDev @trungnotchung @winprn