fix: merge new vertices when drp is missing #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamegraph.com reportCreated by Flamegraph.com Github Action |
trungnotchung
changed the title
trungnotchung
force-pushed
the
fix/merge-without-drp
branch
from
b2a0a35 to
d6bbb18
Compare
trungnotchung
requested review from
JanLewDev,
winprn,
hoangquocvietuet and
magnified103
as code owners
sfroment
force-pushed
the
fix/merge-without-drp
branch
from
d6bbb18 to
62cee3b
Compare
sfroment
force-pushed
the
fix/merge-without-drp
branch
from
62cee3b to
aede814
Compare
sfroment
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
mergeWithoutDrp_checkWriterPermissionbecause we still have the acl state even if the drp is missingRelated Issues and PRs
Added/updated tests?
Additional Info
add instructions or screenshots on what you might think is relevant or instructions on how to manually test it
[optional] Do we need to perform any post-deployment tasks?