Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vertex not found #445

Merged
merged 12 commits into from
Feb 12, 2025
Merged

fix: vertex not found #445

merged 12 commits into from
Feb 12, 2025

Conversation

trungnotchung
Copy link
Member

@trungnotchung trungnotchung commented Feb 7, 2025 •
edited
Loading

  • move all condition for new vertices from addVertex to drpObject
  • create function validateVertexto validate vertex before merging this vertex in both _mergeWithDrpand _mergeWithoutDrp
  • apply operation when _computeDRPand _computeObjectACL
  • added tests to check this condition
  • modified existing tests with these changes
  • tested with our example
    resolve Fix LCA Vertex not found #423 Missing dependencies trigger LCA error during merge #431

@trungnotchung trungnotchung marked this pull request as draft February 7, 2025 04:54
@trungnotchung trungnotchung marked this pull request as ready for review February 7, 2025 05:27
d-roak
d-roak approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@d-roak d-roak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d-roak d-roak self-requested a review February 7, 2025 14:13
@d-roak d-roak mentioned this pull request Feb 10, 2025
Closed
anhnd350309
anhnd350309 approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@anhnd350309 anhnd350309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

d-roak
d-roak reviewed Feb 11, 2025
View reviewed changes
@d-roak d-roak merged commit fa82b06 into main Feb 12, 2025
13 checks passed
sfroment pushed a commit that referenced this pull request Feb 13, 2025
@trungnotchung @winprn @sfroment
fix: vertex not found (#445)
88fde43 
Co-authored-by: winprn <[email protected]>
@trungnotchung trungnotchung deleted the fix/vertex-not-found branch March 5, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-roak d-roak d-roak approved these changes

@magnified103 magnified103 magnified103 approved these changes

@anhnd350309 anhnd350309 anhnd350309 approved these changes

@JanLewDev JanLewDev Awaiting requested review from JanLewDev JanLewDev is a code owner

@winprn winprn Awaiting requested review from winprn winprn is a code owner

@hoangquocvietuet hoangquocvietuet Awaiting requested review from hoangquocvietuet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix LCA Vertex not found
5 participants
@trungnotchung @d-roak @magnified103 @winprn @anhnd350309