Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: modify acl state #421

Merged
merged 7 commits into from
Feb 4, 2025
Merged

feat: modify acl state #421

merged 7 commits into from
Feb 4, 2025

Conversation

anhnd350309
Copy link
Contributor

@anhnd350309 anhnd350309 commented Feb 3, 2025 •
edited
Loading

Description

This PR consolidates _admin, _finalitySigners, _writers, and related variables into _authorizedPeers to make state of being more efficient

todo

  • change acl state
  • add some testcase

close #385

@anhnd350309 anhnd350309 changed the title feat: init modify acl state feat: modify acl state Feb 3, 2025
@anhnd350309 anhnd350309 marked this pull request as ready for review February 3, 2025 09:34
d-roak
d-roak reviewed Feb 4, 2025
View reviewed changes
vitest.workspace.ts Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to add this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed this vitest docs: https://vitest.dev/guide/workspace
We have a lot of files vite.config.mts, and we need a file to manage them. So I create this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we can change the root vite.config.mts and add a workspace in this root file

@d-roak d-roak merged commit b1b0b90 into main Feb 4, 2025
12 checks passed
sfroment added a commit that referenced this pull request Feb 5, 2025
@sfroment
Merge branch 'main' into feat/enhance_coverage
c120f89 
* main:
  improve: move only test function (#428)
  fix: hash validation  (#422)
  feat: modify acl state (#421)
  feat: wait for node to be dialable after libp2p.start (#418)
  chore(deps): bump it-length-prefixed from 9.1.0 to 10.0.0 (#425)
@d-roak d-roak deleted the feat/modify-acl-state branch February 6, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-roak d-roak d-roak approved these changes

@JanLewDev JanLewDev Awaiting requested review from JanLewDev JanLewDev is a code owner

@trungnotchung trungnotchung Awaiting requested review from trungnotchung trungnotchung is a code owner

@winprn winprn Awaiting requested review from winprn winprn is a code owner

@hoangquocvietuet hoangquocvietuet Awaiting requested review from hoangquocvietuet

@magnified103 magnified103 Awaiting requested review from magnified103 magnified103 is a code owner

@sfroment sfroment Awaiting requested review from sfroment sfroment is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify ACL structure
2 participants
@anhnd350309 @d-roak