Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add apply operation error handler #383

Merged
merged 4 commits into from
Jan 21, 2025
Merged

fix: add apply operation error handler #383

merged 4 commits into from
Jan 21, 2025

Conversation

hoangquocvietuet
Copy link
Contributor

Issue #358

anhnd350309
anhnd350309 approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@anhnd350309 anhnd350309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

trungnotchung
trungnotchung reviewed Jan 21, 2025
View reviewed changes
Copy link
Member

@trungnotchung trungnotchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add some tests for merging case

@hoangquocvietuet
Copy link
Contributor Author

add some tests for merging case

Which case ser

winprn
winprn approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@winprn winprn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

trungnotchung
trungnotchung approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@trungnotchung trungnotchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hoangquocvietuet hoangquocvietuet force-pushed the fix/apply_operation_error_handler branch from 077816a to 971940e Compare January 21, 2025 09:50
d-roak
d-roak approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@d-roak d-roak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d-roak d-roak merged commit 03fa9b7 into main Jan 21, 2025
12 checks passed
@d-roak d-roak deleted the fix/apply_operation_error_handler branch January 24, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-roak d-roak d-roak approved these changes

@trungnotchung trungnotchung trungnotchung approved these changes

@winprn winprn winprn approved these changes

@anhnd350309 anhnd350309 anhnd350309 approved these changes

@JanLewDev JanLewDev Awaiting requested review from JanLewDev JanLewDev is a code owner

@magnified103 magnified103 Awaiting requested review from magnified103 magnified103 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hoangquocvietuet @d-roak @trungnotchung @winprn @anhnd350309