fix: pass addr sorting to connection manager to always dial in a predeterministic way #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manager Signed-off-by: Sacha Froment <[email protected]>
d-roak
reviewed
Jan 14, 2025
There was a problem hiding this comment.
instead of this, can we look into the issue with the native auto dialer?
libp2p/js-libp2p-pubsub-peer-discovery#149
ChainSafe/js-libp2p-gossipsub#510
|
Yup ! |
|
Ported in #363 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aim to make the dial consistent even when it's not coming from the identify.
How ? By passing the addr sorting on the connection manager side, which is invoked by calculateMultiaddrs in the libp2p code, which it self is called in dial.