Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic playwright test #343

Merged
merged 13 commits into from
Feb 5, 2025
Merged

feat: add basic playwright test #343

merged 13 commits into from
Feb 5, 2025

Conversation

sfroment
Copy link
Member

@sfroment sfroment commented Jan 10, 2025

Still a bit wip but I was wishing to get the new workflow running in the github env not only act

Signed-off-by: Sacha Froment [email protected]

@sfroment sfroment force-pushed the feat/add-e2e-testing branch 3 times, most recently from 0ffdaf8 to 0a7630c Compare January 10, 2025 16:21
@d-roak d-roak marked this pull request as draft January 10, 2025 20:10
@sfroment sfroment force-pushed the feat/add-e2e-testing branch 14 times, most recently from d3f241e to 15b005c Compare January 13, 2025 14:35
@sfroment sfroment marked this pull request as ready for review January 13, 2025 14:39
@sfroment
Copy link
Member Author

sfroment commented Jan 13, 2025

This is now ready for review, few big things are also added in it like the fact that now caller can subscribe to node event and pubsub event, it is in order to have a more reliable way of updating the peer list

@sfroment sfroment mentioned this pull request Jan 13, 2025
@d-roak d-roak linked an issue Jan 14, 2025 that may be closed by this pull request
@sfroment sfroment force-pushed the feat/add-e2e-testing branch from 5362a28 to 7402876 Compare January 14, 2025 14:10
@sfroment sfroment requested a review from anhnd350309 January 14, 2025 14:10
0xaldric

This comment was marked as duplicate.

Copy link
Contributor

@anhnd350309 anhnd350309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfroment sfroment force-pushed the feat/add-e2e-testing branch from d6953e7 to c2ec9a4 Compare February 4, 2025 14:03
Signed-off-by: Sacha Froment <[email protected]>

chore: debug

Signed-off-by: Sacha Froment <[email protected]>

chore: add console

Signed-off-by: Sacha Froment <[email protected]>

chore: reduce the discovery interval and bettter way of knowing when we have a subscriber

Signed-off-by: Sacha Froment <[email protected]>

chore: add url on bootstrap

hopefully this will make playwright wait for the port to be opened

Signed-off-by: Sacha Froment <[email protected]>

chore: display which browser return a weird ICE trouble

Signed-off-by: Sacha Froment <[email protected]>

chore: test with ice local authorized

Signed-off-by: Sacha Froment <[email protected]>

chore: enable loopback

Signed-off-by: Sacha Froment <[email protected]>

chore: see the rtc config

Signed-off-by: Sacha Froment <[email protected]>

chore: add list

Signed-off-by: Sacha Froment <[email protected]>

chore: clean up

Signed-off-by: Sacha Froment <[email protected]>

chore: clean up

Signed-off-by: Sacha Froment <[email protected]>

chore: clean up

Signed-off-by: Sacha Froment <[email protected]>

chore: clean up

Signed-off-by: Sacha Froment <[email protected]>

chore: add comment

Signed-off-by: Sacha Froment <[email protected]>

chore: quick fix

Signed-off-by: Sacha Froment <[email protected]>

chore: quick fix

Signed-off-by: Sacha Froment <[email protected]>

Update .github/workflows/playwright.yml

Co-authored-by: Oak <[email protected]>

chore: .gitignore

Co-authored-by: Oak <[email protected]>

chore: update html

Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
@sfroment sfroment force-pushed the feat/add-e2e-testing branch from c2ec9a4 to d4aa8d9 Compare February 4, 2025 15:58
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
@d-roak d-roak merged commit c9c9d88 into main Feb 5, 2025
13 checks passed
sfroment added a commit that referenced this pull request Feb 5, 2025
* origin:
  chore(deps-dev): bump vitest from 2.1.8 to 2.1.9 in the npm_and_yarn group (#436)
  feat: add basic playwright test (#343)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add browser testing
4 participants