Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sign vertices before sending #337

Merged
merged 3 commits into from
Jan 10, 2025
Merged

fix: sign vertices before sending #337

merged 3 commits into from
Jan 10, 2025

Conversation

trungnotchung
Copy link
Member

@trungnotchung trungnotchung commented Jan 10, 2025 •
edited
Loading

fixes #336

@trungnotchung trungnotchung marked this pull request as ready for review January 10, 2025 05:38
@magnified103 magnified103 force-pushed the fix/sign-vertices-before-sending branch from ba3436e to 3ab44fc Compare January 10, 2025 06:06
d-roak
d-roak approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@d-roak d-roak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d-roak d-roak merged commit 8ee5907 into main Jan 10, 2025
22 checks passed
@d-roak d-roak deleted the fix/sign-vertices-before-sending branch January 13, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-roak d-roak d-roak approved these changes

@anhnd350309 anhnd350309 Awaiting requested review from anhnd350309 anhnd350309 is a code owner

@sfroment sfroment Awaiting requested review from sfroment sfroment is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ACL: signatures in the UPDATE message are missing
2 participants
@trungnotchung @d-roak