-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing certificate pinning code and references #361
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
==========================================
+ Coverage 47.89% 53.59% +5.70%
==========================================
Files 17 16 -1
Lines 1570 1403 -167
Branches 137 136 -1
==========================================
Hits 752 752
+ Misses 776 609 -167
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, pending adding the right link. cc @april can you take a look at the messaging?
Removing certificate pinning code as we no longer want the SDK to enforce the certificate pinning. The README will be updated on how this should be achieved by the SDK users if desired.
This also removes the references to the cert pinning function from the example projects that had it.
Checklist
General Contributing
Is This a Code Change?
Validation