Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing certificate pinning code and references #361

Merged
merged 5 commits into from
May 22, 2024
Merged

Conversation

eli-iser
Copy link
Contributor

Removing certificate pinning code as we no longer want the SDK to enforce the certificate pinning. The README will be updated on how this should be achieved by the SDK users if desired.
This also removes the references to the cert pinning function from the example projects that had it.

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • SDK Code Change
  • Example/Test Code Change

Validation

  • Does this code build successfully?
  • Do all tests pass?
  • Does Stylecop pass?

@eli-iser eli-iser requested a review from sahujapersonal May 15, 2024 21:05
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.59%. Comparing base (0ff5668) to head (12f0be6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
+ Coverage   47.89%   53.59%   +5.70%     
==========================================
  Files          17       16       -1     
  Lines        1570     1403     -167     
  Branches      137      136       -1     
==========================================
  Hits          752      752              
+ Misses        776      609     -167     
  Partials       42       42              
Flag Coverage Δ
integration 50.10% <ø> (+5.32%) ⬆️
unit 10.54% <ø> (+1.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@maxbelanger maxbelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending adding the right link. cc @april can you take a look at the messaging?

@eli-iser eli-iser merged commit f8ff2aa into main May 22, 2024
12 checks passed
@eli-iser eli-iser deleted the remove-cert-pinning branch May 22, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants