Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting the spelling of the principal username in the Presto client. #326

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

Ralnoc
Copy link
Contributor

@Ralnoc Ralnoc commented Apr 16, 2020

Correcting the spelling in the presto.py from principle_username to principal_username.

Please let me know if we need to retain the original variable for backwards compatibility and I'll update the PR accordingly.

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #326 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #326   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files          14       14           
  Lines        1526     1526           
  Branches      165      165           
=======================================
  Hits         1423     1423           
  Misses         75       75           
  Partials       28       28           
Impacted Files Coverage Δ
pyhive/presto.py 85.98% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbf7941...c8ec018. Read the comment docs.

@bkyryliuk
Copy link
Collaborator

@Ralnoc this is good enough. I'll add note to the release notes.

@bkyryliuk bkyryliuk merged commit 3ac95b5 into dropbox:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants