Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty slides with custom content #837

Closed
boreyko1 opened this issue May 13, 2022 · 1 comment
Closed

Empty slides with custom content #837

boreyko1 opened this issue May 13, 2022 · 1 comment

Comments

@boreyko1
Copy link

Describe the bug
Hi! It seems like there is a bug when using custom content with React components. Sometimes there are empty slides at random indexes. Unfortunately, I couldn't identify what causes this

To Reproduce
Reproduction link – https://stackblitz.com/edit/nextjs-db1zk4?file=pages/index.js.
Both galleries (simple <img /> tag and a custom React component) have the same bug with missing content

Expected behavior
All slides are rendered correctly

Screenshots

Empty content in devtools image

Additional context
Let me know if I can help somehow. Thanks!
irudoy added a commit that referenced this issue May 14, 2022
@irudoy
fix(custom-content): reset portal if slideData has no content, and on…
031dfcf 
… `close` (#837)
@irudoy
Copy link
Contributor

irudoy commented May 14, 2022

Thanks for reporting and reproduction! Should be fixed in v2.2.1

@irudoy irudoy closed this as completed May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@irudoy @boreyko1