Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] 네트워크가 연결안된 상태로 컨트리뷰트 화면 진입시 앱이 종료 됨 #238

Merged
merged 10 commits into from
Aug 26, 2023
Merged

[Bug] 네트워크가 연결안된 상태로 컨트리뷰트 화면 진입시 앱이 종료 됨 #238

merged 10 commits into from
Aug 26, 2023

Conversation

JeonK1
Copy link
Contributor

@JeonK1 JeonK1 commented Aug 24, 2023 •
edited
Loading

Issue

Overview (Required)

  • 네트워크 요청하는 화면(Home, Bookmark, Contributor, Session) 화면에 대해 Network 요청 중 에러발생시 Snackbar 생성
  • Network 연결 끊김(UnknownHostException) 으로 인한 에러는 "네트워크 연결이 원활하지 않습니다" 를 노출하며, 기타 에러는 "알 수 없는 오류가 발생하였습니다" 로 처리
  • stateFlow 생성 시 catch { } 를 통해 에러발생 시 channel 을 통해 에러이벤트 전달 및 snackbar 노출하는 로직으로 구성

Screenshot

name Before After
main crash error
bookmark crash error
contributor crash error
session crash error

@github-actions
Copy link

github-actions bot commented Aug 24, 2023 •
edited
Loading

Test Results

18 tests   18 ✔️  8s ⏱️
11 suites    0 💤
11 files      0 ❌

Results for commit 01465e8.

♻️ This comment has been updated with latest results.

laco-dev
laco-dev approved these changes Aug 26, 2023
View reviewed changes
Copy link
Contributor

@laco-dev laco-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정사항 확인했습니다.
고생 많으셨습니다. 🙏🏻

@laco-dev laco-dev merged commit 16e86b9 into droidknights:main Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laco-dev laco-dev laco-dev approved these changes

Assignees

@JeonK1 JeonK1

Labels
2023
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

네트워크가 연결안된 상태로 컨트리뷰트 화면 진입시 앱이 종료 됨
3 participants
@JeonK1 @laco-dev @taehwandev