[Contributor] 컨트리뷰터 카드 클릭 시 Github URL 이동 #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laco-dev
reviewed
Aug 21, 2023
| @@ -197,7 +199,10 @@ private fun ContributorItem( | |||
| lightId = R.drawable.ic_contributor_placeholder_lightmode, | |||
| darkId = R.drawable.ic_contributor_placeholder_darkmode, | |||
| ) | |||
| KnightsCard(modifier = modifier) { | |||
| KnightsCard( | |||
| onClick = { uriHandler.openUri(contributor?.githubUrl.orEmpty()) }, | |||
There was a problem hiding this comment.
uriHandler.openuri("") 가 호출되면 예외가 발생하며 앱이 종료됩니다.
안전하게 호출될 수 있도록 해보면 어떨까요?
There was a problem hiding this comment.
Intent data로 빈 문자열이 전달될 경우 발생하는 예외에 대해 확인했습니다.
이 경우 2가지 대안을 고려중인데 어떤게 기획에 더 부합한지 의견 구하고 싶습니다.
- droidknights 페이지로 이동
- 클릭 이벤트 무시
감사합니다.
There was a problem hiding this comment.
@JaesungLeee
후원사에 대한 기능이기 때문에 이벤트를 무시하는 방향이 좋을 것 같습니다.
*클릭했더니 홈페이지로 이동하는것으로 기대하기 어려움
이 경우 클릭 enabled 처리를 같이 확인 해 주시면 됩니다.
There was a problem hiding this comment.
반영했습니다. 612f249
KnightsCard 클릭 시 github 페이지로 이동
JaesungLeee
force-pushed
the
feature/#224
branch
from
612f249 to
f45aafe
Compare
wisemuji
approved these changes
Aug 23, 2023
| KnightsCard(modifier = modifier) { | ||
|
|
||
| KnightsCard( | ||
| enabled = contributor?.githubUrl?.isNotEmpty() ?: false, |
There was a problem hiding this comment.
이런 로직은 별도의 UI 모델을 만들어 관리하는것도 테스트하기 편할 것 같아요. 지금 상태로도 괜찮으니 꼭 반영하진 않으셔도 됩니다 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Screenshot