Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color, Type 스타일 추가 #12

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Color, Type 스타일 추가 #12

merged 3 commits into from
Jul 4, 2023

Conversation

wisemuji
Copy link
Member

Issue

Overview (Required)

  • 디자인 시스템 모듈에 Color, Type 스타일 추가

Remark

  • darkColorScheme은 추후에 수정될 예정입니다.
  • Type의 경우 스타일별 weight이 상이하기에 별도로 정의하진 않았습니다.
    • 더 좋은 방법이 있다면 제안해주세요.

@wisemuji wisemuji added the enhancement New feature or request label Jun 26, 2023
@wisemuji wisemuji requested a review from laco-dev June 26, 2023 12:15
@wisemuji wisemuji self-assigned this Jun 26, 2023
@wisemuji
Copy link
Member Author

Material Typography에 맞추기보다 Custom하게 정의하는게 낫나 싶기도 하네요 🤔

laco-dev
laco-dev requested changes Jun 27, 2023
View reviewed changes
core/designsystem/src/main/java/com/droidknights/app2023/core/designsystem/theme/Theme.kt
Comment on lines +19 to +21
primary = Neon01,
secondary = Green01,
tertiary = Yellow01
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

머티리얼을 따라간다면 머티리얼 테마에 맞도록 팔레트(스킴)를 정의해야 하지 않을까요?

https://github.com/android/nowinandroid/blob/main/core/designsystem/src/main/java/com/google/samples/apps/nowinandroid/core/designsystem/theme/Theme.kt

https://m3.material.io/styles/color/the-color-system/key-colors-tones

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디자이너분과 따로 소통해보겠습니다.

core/designsystem/src/main/java/com/droidknights/app2023/core/designsystem/theme/Type.kt Show resolved Hide resolved
core/designsystem/src/main/java/com/droidknights/app2023/core/designsystem/theme/Color.kt Outdated Show resolved Hide resolved
laco-dev
laco-dev approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@laco-dev laco-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wisemuji
테마 관련 결정사항 이슈로 나눠서 작업 해주시면 될 것 같습니다.

@wisemuji wisemuji mentioned this pull request Jul 4, 2023
Closed
@wisemuji
Copy link
Member Author

wisemuji commented Jul 4, 2023

#18 에서 이어서 작업하겠습니다.

@wisemuji wisemuji merged commit 4b64d33 into droidknights:main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laco-dev laco-dev laco-dev approved these changes

Assignees

@wisemuji wisemuji

Labels
2023 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

컬러, 폰트 스타일 추가
3 participants
@wisemuji @laco-dev @taehwandev