Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Home] :feature:home 모듈 생성 #10

Merged
merged 3 commits into from
Jun 26, 2023
Merged

[Home] :feature:home 모듈 생성 #10

merged 3 commits into from
Jun 26, 2023

Conversation

laco-dev
Copy link
Contributor

Issue

Overview (Required)

  • home feature에 대한 안드로이드 모듈 추가

Etc

  • feature 컨벤션 플러그인이 :core:domain 모듈을 공통으로 의존하도록 변경

@laco-dev laco-dev requested a review from wisemuji June 25, 2023 07:25
wisemuji
wisemuji approved these changes Jun 25, 2023
View reviewed changes
Copy link
Member

@wisemuji wisemuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ☺️

build-logic/src/main/kotlin/droidknights.android.feature.gradle.kts Show resolved Hide resolved
@laco-dev laco-dev merged commit da6bae5 into droidknights:main Jun 26, 2023
@laco-dev laco-dev changed the title :feature:home 모듈 생성 [Home] :feature:home 모듈 생성 Jul 4, 2023
@laco-dev laco-dev added the enhancement New feature or request label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wisemuji wisemuji wisemuji approved these changes

Assignees

@laco-dev laco-dev

Labels
2023 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Home] feature-home 모듈 생성
3 participants
@laco-dev @wisemuji @taehwandev