-
-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kit bugfixes #4043
Open
L-Mario564
wants to merge
21
commits into
drizzle-team:beta
Choose a base branch
from
L-Mario564:kit-bugfixes-2
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Kit bugfixes #4043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses 19 bugs:
#3254
bit
data type in PG generated with quotes around it. Not anymore.#2630
Added a proper migration strategy when altering a
serial
column to ainteger generated always as identity
column in PG.Before:
Now:
#3004
The value for
maxvalue
for the created sequence when usingbigint
data type was incorrect. This is now the real 64-bit integer limit.#3713
Check constraints didn't insert parameterized values.
Before:
Now:
#3867
In the issue reported, the user had a .DS_Store file that Drizzle was attempting to read as a JSON file. Added the extra check to the internal
prepareOutFolder
function to only include.json
files.#3795
This doesn't seem to be a bug present in latest. I added tests to confirm this.
#3609
Default value for
bigint
data type wasn't handled properly, leading to an error when attempting toJSON.stringify
it.#3679 & #3820
Using an non-alphanumeric character within a sequence's name (like a "-") would result in changes being applied when there weren't any. This is now fixed.
#3347, #2806, #3685 & #2454
Fixed issues with
geometry(point)
serialization:1-
geometry(point)
got instrospected asgeometry(Point)
.2- Default value was serialized as
[Object object]
.#3884
Prevent type error when the table belonging to a check constraint wasn't found during introspection in MySQL.
#3585
This seems to have been fixed in newer versions of Kit. Added a test to verify such.
#3559 & #3549
Empty strings upon introspection are now handled correctly.
#1680
Fixed in latest. Added test to verify.
#2888
Composite unique constraint got recreated in Postgres even if the column order hasn't been modified. Fixed by retrieving the order of the constraint's columns upon introspection.