Replace polyfill.io with fastly's alternative #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't it better to refrain from directly linking to 3rd party libraries in this way? This moves the attack surface from a Chinese supplier to probably a party susceptible to surveillance from other sides ;) |
pasqu4le
force-pushed
the
OEI-128-polyfill
branch
from
77445b2 to
7749a9e
Compare
|
You are right, I didn't do it right away because I wasn't sure if we needed the service at all. It turns out that we can remove it entirely, so I updated this PR now. |
robvandenbogaard
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the issue: OEI-128
For reference, see: https://sansec.io/research/polyfill-supply-chain-attack