Use URI encoding for search state #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -175,7 +175,7 @@ $.widget("ui.search_ui", { | |||
|
|
|||
| var me = this, | |||
| hash = window.location.hash.substring(1, window.location.hash.length), | |||
| json = atob(hash), | |||
| json = decodeURIComponent(hash), | |||
There was a problem hiding this comment.
Should we make it backward compatible? So that if we feed it a(n existing) link with btoa encoded hash, that it decodes using aotb?
There was a problem hiding this comment.
Discussed with Colin: We can make it compatible by enclosing the decode in a try catch.
robvandenbogaard
approved these changes
Dec 14, 2022
cdfa
force-pushed
the
search-uri-encoding
branch
from
3c9774e to
ca4e9ec
Compare
added 3 commits
December 15, 2022 12:15
Instead of base64 encoding, which would fail on non ASCII characters
cdfa
force-pushed
the
search-uri-encoding
branch
from
ca4e9ec to
7d53399
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of base64 encoding, which would fail on non ASCII characters