Elasticsearch2 Adlib support #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mworrell
requested review from
cdfa and
robvandenbogaard
and removed request for
robvandenbogaard
cdfa
approved these changes
Oct 24, 2022
cdfa
force-pushed
the
elasticsearch2-adlib
branch
from
5e21973 to
4a97ddd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for mod_elasticsearch2 to the Adlib/collection modules.
In ES7+ the _type is removed, as we used it for the Adlib database reference when storing documents we now have to combine the type and priref of a record to make an unique document
_id(as multiple databases can have the same priref).The filter
collection_object_urlcan now be used to makecollection_objecturls, this instead of manually combining the type and id in the template (or Erlang code).See also: driebit/mod_elasticsearch2#5