mod_ginger_base: show in pager if result count is an estimate #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdfa
reviewed
Oct 12, 2022
cdfa
approved these changes
Oct 21, 2022
mworrell
force-pushed
the
pager-estimate
branch
from
fa68fa7 to
28f452b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem where the pager displays an amount of hits that seems to be very accurate, which gives the suggestion that the displayed number is exact when in fact it is an estimate.
Also update the NL translations.
(Needs the 0.71 or 0.x branch for the
round_significantfilter)