Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix processMakernote cannot lowerCase Samsung maker #506

Merged
merged 2 commits into from
Oct 8, 2020
Merged

Fix processMakernote cannot lowerCase Samsung maker #506

merged 2 commits into from
Oct 8, 2020

Conversation

dohykim
Copy link
Contributor

@dohykim dohykim commented Oct 8, 2020

drewnoakes
drewnoakes reviewed Oct 8, 2020
View reviewed changes
Tests/com/drew/metadata/exif/SamsungType2MakernoteTest.java Outdated

import static org.junit.Assert.assertNotNull;

public class SamsungType2MakernoteTest
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including a unit test, but actually we don't generally add images to this repo as the repo becomes too large. We have a separate repo, https://github.com/drewnoakes/metadata-extractor-images, which has lots of images and the output from this library, the output from the .NET version, and the differences between them where such differences exist.

Please remove the test image file and the unit test from here. If you're happy to share the image, I'll add it to the image library which will allow us to track the output over time and verify there is no regression. It will also encourage a fix on the .NET side, to stamp out the difference in outputs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your kind explanation.
and I'm glad to share the image!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@drewnoakes drewnoakes merged commit 3d21ad9 into drewnoakes:master Oct 8, 2020
drewnoakes added a commit to drewnoakes/metadata-extractor-images that referenced this pull request Oct 8, 2020
@drewnoakes
Fix some Samsung makernote detection
e90c711 
drewnoakes/metadata-extractor#505
drewnoakes/metadata-extractor#506
drewnoakes/metadata-extractor-dotnet#273
@drewnoakes
Copy link
Owner

Released in 2.15.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewnoakes drewnoakes drewnoakes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dohykim @drewnoakes