Spanify various things and use UTF-8 literals #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@drewnoakes Ready for review. |
|
Thanks @iamcarbon this is great. I've started spanifying a few things locally too, though we don't have much overlap which is great. I'm looking mostly at the deserialization stuff, using
I think that's fine, as it's not an API I'd expect many to use directly (if any), though I'm surprised it didn't require a change to the API files. |
drewnoakes
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Posting for early feedback.
There is one public API change, which I'm happy to revert if we have a no-breaking changes policy.
protected byte[] PreambleByteswas changed toprotected ReadOnlySpan<byte> PreambleBytesThis also prevents the mutation of the underlying data.