Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheets-ui): support disable defined name #4854

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Mar 19, 2025

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@weird94 weird94 requested review from jikkai and wzhudev as code owners March 19, 2025 03:58
Copy link

github-actions bot commented Mar 19, 2025

View Deployment

📑 Demo (React@19) Demo (React@16) 📚 Storybook
🔗 Preview link 🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Mar 19, 2025

Playwright test results

passed  25 passed

Details

stats  25 tests across 12 suites
duration  6 minutes, 6 seconds
commit  47f454f
info  For more information, see full report

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 34.13%. Comparing base (64034c7) to head (47f454f).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ges/sheets-ui/src/views/formula-bar/FormulaBar.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4854      +/-   ##
==========================================
+ Coverage   34.11%   34.13%   +0.01%     
==========================================
  Files        2627     2627              
  Lines      136998   136999       +1     
  Branches    30413    30414       +1     
==========================================
+ Hits        46742    46760      +18     
+ Misses      90256    90239      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weird94 weird94 merged commit 0565b0d into dev Mar 19, 2025
9 checks passed
@weird94 weird94 deleted the feat/support-disable-defined-name branch March 19, 2025 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants