Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove redundant code #3575

Merged
merged 1 commit into from
Sep 25, 2024
Merged

refactor: remove redundant code #3575

merged 1 commit into from
Sep 25, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Sep 25, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@jikkai jikkai requested a review from wzhudev as a code owner September 25, 2024 08:13
Copy link

github-actions bot commented Sep 25, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 25, 2024

Playwright test results

passed  8 passed

Details

stats  8 tests across 3 suites
duration  2 minutes, 3 seconds
commit  5279910
info  For more information, see full report

@jikkai jikkai force-pushed the refactor/remove-code branch 2 times, most recently from 27c4701 to 3509616 Compare September 25, 2024 08:21
@jikkai jikkai requested a review from DR-Univer as a code owner September 25, 2024 08:21
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.84%. Comparing base (95935e2) to head (5279910).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3575      +/-   ##
==========================================
- Coverage   31.84%   31.84%   -0.01%     
==========================================
  Files        2194     2194              
  Lines      115185   115198      +13     
  Branches    25369    25374       +5     
==========================================
  Hits        36680    36680              
- Misses      78505    78518      +13     
Flag Coverage Δ
31.84% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai force-pushed the refactor/remove-code branch from 3509616 to 5279910 Compare September 25, 2024 08:32
@jikkai jikkai merged commit 2a61446 into dev Sep 25, 2024
9 checks passed
@jikkai jikkai deleted the refactor/remove-code branch September 25, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants