-
-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: data-validation model #3383
Conversation
Playwright Test Report
🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪 |
…r into refactor/data-validation
Origin Title: refactor: data-validation model Title: refactor: data-validation model 废弃了 DataVlidationManager,原有的问题:
Pull Request Checklist
Breaking changes
|
@yuhongz 修改了 commands,需要看一下是否会对历史记录功能有影响 |
@yuhongz modified the commands. We need to check whether it will affect the history function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A conclusion: plugin sheets-data-validation
would be separated into two plugins in the future in favor of server side computing.
Overall LGTM for now.
废弃了 DataVlidationManager,原有的问题:
close #3279
close #3399
Pull Request Checklist
Breaking changes
@univerjs/data-validation
was removed, please use command in@univerjs/sheets-data-validation
instead. More info: https://github.com/dream-num/univer/pull/3383/files#diff-c7335b3062d7277e08d8b224a507c171c8edbbb77668296876aa3c600c48bfc6