Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: data-validation model #3383

Merged
merged 35 commits into from
Sep 12, 2024
Merged

refactor: data-validation model #3383

merged 35 commits into from
Sep 12, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Sep 9, 2024

废弃了 DataVlidationManager,原有的问题:

  1. 使 data-validation 和 sheets-data-validation耦合,无法实现懒加载
  2. 无法扩展为后续的docs-data-validation, slide-data-validation

close #3279
close #3399

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Breaking changes

  1. commands exported from @univerjs/data-validation was removed, please use command in @univerjs/sheets-data-validation instead. More info: https://github.com/dream-num/univer/pull/3383/files#diff-c7335b3062d7277e08d8b224a507c171c8edbbb77668296876aa3c600c48bfc6

Copy link

github-actions bot commented Sep 9, 2024

Playwright Test Report

#10826974845

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 397 lines in your changes missing coverage. Please review.

Project coverage is 30.49%. Comparing base (d016318) to head (3a2e907).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...lidation/src/models/sheet-data-validation-model.ts 0.00% 145 Missing ⚠️
...ata-validation/src/models/data-validation-model.ts 0.00% 69 Missing ⚠️
...n/src/commands/commands/data-validation.command.ts 0.00% 56 Missing ⚠️
...validation/src/controllers/dv-render.controller.ts 0.00% 22 Missing ⚠️
...ta-validation/src/validators/checkbox-validator.ts 0.00% 17 Missing ⚠️
...s-data-validation/src/validators/date-validator.ts 0.00% 8 Missing ⚠️
...n/src/commands/commands/data-validation.command.ts 0.00% 7 Missing ⚠️
...-validation/src/controllers/dv-alert.controller.ts 0.00% 7 Missing ⚠️
...ta-validation/src/services/dv-validator-service.ts 0.00% 7 Missing ⚠️
...ackages/sheets-data-validation/src/utils/create.ts 0.00% 7 Missing ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3383      +/-   ##
==========================================
- Coverage   30.50%   30.49%   -0.02%     
==========================================
  Files        2133     2132       -1     
  Lines      111082   111135      +53     
  Branches    24260    24282      +22     
==========================================
  Hits        33889    33889              
- Misses      77193    77246      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@univer-bot
Copy link

univer-bot bot commented Sep 11, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Origin Title: refactor: data-validation model

Title: refactor: data-validation model


废弃了 DataVlidationManager,原有的问题:

  1. 使 data-validation 和 sheets-data-validation耦合,无法实现懒加载
  2. 无法扩展为后续的docs-data-validation, slide-data-validation

close #3279
close #3399

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Breaking changes

  1. commands exported from @univerjs/data-validation was removed, please use command in @univerjs/sheets-data-validation instead. More info: https://github.com/dream-num/univer/pull/3383/files#diff-c7335b3062d7277e08d8b224a507c171c8edbbb77668296876aa3c600c48bfc6

@weird94 weird94 requested review from jikkai and Jocs as code owners September 11, 2024 07:11
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Sep 11, 2024
@univer-bot univer-bot bot removed the qa:rejected label Sep 11, 2024
@wzhudev
Copy link
Member

wzhudev commented Sep 11, 2024

@yuhongz 修改了 commands,需要看一下是否会对历史记录功能有影响

@univer-bot
Copy link

univer-bot bot commented Sep 11, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@yuhongz modified the commands. We need to check whether it will affect the history function.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A conclusion: plugin sheets-data-validation would be separated into two plugins in the future in favor of server side computing.

Overall LGTM for now.

@weird94 weird94 requested a review from ybzky as a code owner September 12, 2024 08:20
@weird94 weird94 merged commit f61277f into dev Sep 12, 2024
7 of 8 checks passed
@weird94 weird94 deleted the refactor/data-validation branch September 12, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
3 participants