Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(filter): refactor filter for demo #3194

Merged
merged 6 commits into from
Aug 27, 2024
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Aug 26, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wzhudev wzhudev changed the title fix: fix render related bugs refactor(filter): refactor filter for demo Aug 26, 2024
Copy link

github-actions bot commented Aug 26, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 33.75000% with 53 lines in your changes missing coverage. Please review.

Project coverage is 28.63%. Comparing base (c67fc66) to head (862abd7).
Report is 3 commits behind head on dev.

Files Patch % Lines
.../render-modules/sheets-filter.render-controller.ts 0.00% 13 Missing ⚠️
packages/sheets-ui/src/sheets-ui-plugin.ts 0.00% 7 Missing ⚠️
...ervices/selection/base-selection-render.service.ts 0.00% 6 Missing ⚠️
.../controllers/sheets-filter-ui-mobile.controller.ts 0.00% 5 Missing ⚠️
...s/permission/sheet-permission-render.controller.ts 0.00% 5 Missing ⚠️
packages/sheets/src/sheets-plugin.ts 0.00% 4 Missing ⚠️
packages/sheets-ui/src/mobile-sheets-ui-plugin.ts 0.00% 3 Missing ⚠️
...kages/ui/src/services/shortcut/shortcut.service.ts 0.00% 3 Missing ⚠️
...s/sheets-filter-ui/src/filter-ui-desktop.plugin.ts 0.00% 2 Missing ⚠️
...vices/selection/mobile-selection-render.service.ts 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3194      +/-   ##
==========================================
- Coverage   28.63%   28.63%   -0.01%     
==========================================
  Files        2024     2025       +1     
  Lines      106985   106970      -15     
  Branches    23126    23129       +3     
==========================================
- Hits        30635    30629       -6     
+ Misses      76350    76341       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev force-pushed the refactor/sheets-filter branch from d72743b to 800a31c Compare August 27, 2024 10:04
@wzhudev wzhudev force-pushed the refactor/sheets-filter branch from 800a31c to 9d94a05 Compare August 27, 2024 10:59
@wzhudev wzhudev marked this pull request as ready for review August 27, 2024 11:13
@wzhudev wzhudev merged commit 04ede3f into dev Aug 27, 2024
9 checks passed
@wzhudev wzhudev deleted the refactor/sheets-filter branch August 27, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant