Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conditional-formatting): initialization timing problem #3142

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Aug 21, 2024

close #3036

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 21, 2024
Copy link

github-actions bot commented Aug 21, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.50%. Comparing base (ca21fb8) to head (c3728e9).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3142   +/-   ##
=======================================
  Coverage   27.50%   27.50%           
=======================================
  Files        1981     1981           
  Lines      105179   105178    -1     
  Branches    22696    22696           
=======================================
+ Hits        28925    28931    +6     
+ Misses      76254    76247    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai removed the qa:untested This PR is ready to be tested label Aug 21, 2024
@jikkai jikkai merged commit 7d1c9d6 into dev Aug 21, 2024
14 checks passed
@jikkai jikkai deleted the fix-cf-register-0821 branch August 21, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Cannot find "ConditionalFormattingService" registered by any injector.
2 participants