Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add crosshair highlight plugin for Univer Sheet #3118

Merged
merged 21 commits into from
Aug 23, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Aug 19, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 0.40161% with 248 lines in your changes missing coverage. Please review.

Project coverage is 27.60%. Comparing base (e73fc3c) to head (fa4e455).
Report is 2 commits behind head on dev.

Files Patch % Lines
...s/widgets/crosshair-highlight.render-controller.ts 0.00% 79 Missing ⚠️
packages/sheets-crosshair-highlight/src/util.ts 0.00% 33 Missing ⚠️
...air-highlight/src/commands/operations/operation.ts 0.00% 26 Missing ⚠️
...highlight/src/controllers/crosshair.controller.tsx 0.00% 18 Missing ⚠️
...s/ui/src/views/components/doc-bars/ToolbarItem.tsx 0.00% 16 Missing ⚠️
packages/sheets-crosshair-highlight/src/plugin.ts 0.00% 13 Missing ⚠️
...sshair-highlight/src/services/crosshair.service.ts 0.00% 13 Missing ⚠️
...ght/src/views/widgets/crosshair-highlight-shape.ts 0.00% 11 Missing ⚠️
...hlight/src/views/components/CrosshairHighlight.tsx 0.00% 10 Missing ⚠️
packages/ui/src/views/components/doc-bars/hook.ts 0.00% 9 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3118      +/-   ##
==========================================
- Coverage   27.62%   27.60%   -0.02%     
==========================================
  Files        1984     1994      +10     
  Lines      105585   105808     +223     
  Branches    22798    22820      +22     
==========================================
+ Hits        29172    29213      +41     
- Misses      76413    76595     +182     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev force-pushed the feat/crosshair-highlight branch from e3d2356 to 5c578f6 Compare August 20, 2024 01:49
Copy link

github-actions bot commented Aug 21, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev marked this pull request as ready for review August 22, 2024 00:13
@wzhudev wzhudev force-pushed the feat/crosshair-highlight branch from c6555bd to 71dfb2c Compare August 22, 2024 00:30
@wzhudev wzhudev changed the title feat: init crosshair plugin feat: add crosshair highlight plugin for Univer Sheet Aug 22, 2024
@wzhudev wzhudev added the qa:untested This PR is ready to be tested label Aug 22, 2024
@wzhudev wzhudev assigned wzhudev, zhaolixin7 and oumomomo and unassigned wzhudev Aug 22, 2024
@wzhudev wzhudev merged commit 3e9c34c into dev Aug 23, 2024
8 of 9 checks passed
@wzhudev wzhudev deleted the feat/crosshair-highlight branch August 23, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants