Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheets-data-validation): support dropdown filter & fix paste error on data-validation cell #3057

Merged
merged 19 commits into from
Aug 16, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Aug 14, 2024

close #2974
close #2986

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@weird94 weird94 mentioned this pull request Aug 14, 2024
2 tasks
Copy link

github-actions bot commented Aug 14, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 63 lines in your changes missing coverage. Please review.

Project coverage is 27.47%. Comparing base (ff51551) to head (c9c0ba1).
Report is 5 commits behind head on dev.

Files Patch % Lines
...ets-data-validation/src/widgets/dropdown-widget.ts 0.00% 32 Missing ⚠️
...-data-validation/src/views/list-dropdown/index.tsx 0.00% 26 Missing ⚠️
...s-data-validation/src/validators/date-validator.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3057      +/-   ##
==========================================
- Coverage   27.48%   27.47%   -0.02%     
==========================================
  Files        1980     1980              
  Lines      104719   104739      +20     
  Branches    22601    22610       +9     
==========================================
- Hits        28780    28772       -8     
- Misses      75939    75967      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 changed the title feat(sheets-data-validation): support dropdown filter feat(sheets-data-validation): support dropdown filter & fix paste error on data-validation cell Aug 14, 2024
@weird94 weird94 requested review from jikkai and wzhudev and removed request for jikkai August 14, 2024 09:48
@oumomomo
Copy link

#29
问题1:
模糊搜索需要区分大小写

问题2:
输入非首位字符时,无法搜索到选项
image
image

@univer-bot
Copy link

univer-bot bot commented Aug 14, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

#29
Question 1:
Fuzzy search needs to be case sensitive

Question 2:
Unable to search for options when entering characters other than the first character
image
image

@weird94 weird94 requested a review from yuhongz as a code owner August 14, 2024 12:41
@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge scope:data validation labels Aug 15, 2024
@univer-bot univer-bot bot removed the qa:rejected label Aug 15, 2024
@weird94 weird94 merged commit e2e7d2a into dev Aug 16, 2024
9 checks passed
@weird94 weird94 deleted the feat/support-dropdown-filter branch August 16, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge scope:data validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] dataValidation paste crash Advice on data validation
3 participants