Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs-ui): support doc checklist #2917

Merged
merged 37 commits into from
Aug 6, 2024
Merged

feat(docs-ui): support doc checklist #2917

merged 37 commits into from
Aug 6, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Aug 3, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 2.66667% with 146 lines in your changes missing coverage. Please review.

Project coverage is 27.21%. Comparing base (1817267) to head (f2eb2f2).

Files Patch % Lines
...ackages/docs/src/commands/commands/list.command.ts 0.00% 56 Missing ⚠️
...der-controllers/doc-checklist.render-controller.ts 0.00% 42 Missing ⚠️
.../docs-ui/src/services/doc-hover-manager.service.ts 0.00% 18 Missing ⚠️
...c/components/docs/extensions/font-and-base-line.ts 0.00% 8 Missing ⚠️
...cs/text-selection/text-selection-render-manager.ts 0.00% 6 Missing ⚠️
...s/docs/src/commands/commands/break-line.command.ts 0.00% 5 Missing ⚠️
...es/engine-render/src/basics/document-node-tools.ts 0.00% 5 Missing ⚠️
packages/docs-ui/src/controllers/menu/menu.ts 0.00% 3 Missing ⚠️
.../engine-render/src/components/docs/layout/tools.ts 0.00% 2 Missing ⚠️
...kages/docs-ui/src/controllers/doc-ui.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2917      +/-   ##
==========================================
- Coverage   27.24%   27.21%   -0.04%     
==========================================
  Files        1844     1845       +1     
  Lines       97116    97243     +127     
  Branches    20759    20791      +32     
==========================================
+ Hits        26458    26462       +4     
- Misses      70658    70781     +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 3, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM


const orderListOptions = [
{
value: PresetListType.ORDER_LIST,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These icons should be auto-generated like conditional formatting's icons instead of hard coding.

return;
}

const docDataModel = univerInstanceService.getUniverDocInstance(unitId);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use deprecated API.

@wzhudev
Copy link
Member

wzhudev commented Aug 5, 2024

/update-snapshots

@weird94 weird94 merged commit 4d3c6d3 into dev Aug 6, 2024
7 of 9 checks passed
@weird94 weird94 deleted the feat/doc-checklist branch August 6, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants