-
-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs-ui): support doc checklist #2917
Conversation
…into feat/doc-list-optimize
…into feat/doc-list-optimize
View Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
packages/core/src/types/interfaces/i-document-data-interceptor.ts
Outdated
Show resolved
Hide resolved
|
||
const orderListOptions = [ | ||
{ | ||
value: PresetListType.ORDER_LIST, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These icons should be auto-generated like conditional formatting's icons instead of hard coding.
return; | ||
} | ||
|
||
const docDataModel = univerInstanceService.getUniverDocInstance(unitId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not use deprecated API.
packages/docs-ui/src/controllers/render-controllers/doc-checklist.render-controller.ts
Outdated
Show resolved
Hide resolved
/update-snapshots |
close #xxx
Pull Request Checklist