Add missing dev/test dependency and fix broken test #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TestNetHttpPersistent#test_pipeline` was getting skipped by default, since `net-http-pipeline` wasn't installed as a test dependency. However, when installed, the skipped test was failing with `NoMethodError: undefined method `start' for #<Net::HTTP::Persistent::Connection:0x007fcf0d992d28>`. This adds `net-http-pipeline` as a dev dependency so the test isn't skipped in CI and fixes the test so it passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestNetHttpPersistent#test_pipelinewas getting skipped by default, sincenet-http-pipelinewasn't installed as a test dependency. However, when installed, the skipped test was failing withNoMethodError: undefined method `start' for #<Net::HTTP::Persistent::Connection:0x007fcf0d992d28>.This adds
net-http-pipelineas a dev dependency so the test isn't skipped in CI and fixes the test so it passes.