-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make tests run locally without random gems #103
Conversation
I'm happy to add a Gemfile to make your development experience easier, but only as a change that is both minimal and maintainable. The Gemfile duplicates the dependencies in the Rakefile. Instead add the hoe-bundler plugin (add Use Please remove The Gemfile and Gemfile.lock shouldn't be shipped in the gem, so please remove them from Manifest.txt along with .bundle/config. Also, since the Gemfile.lock should only exist at the root of the clone, please make it |
0ae5456
to
04be0ed
Compare
|
Add an empty
You implied in #101 that you were comfortable reading the source, but now you are not? Then the problem you are running into is that you are looking for documentation on how to get started, so we can fix it with documentation. Changing the official release process to one that's lacking features I use to release this gem to fix a documentation problem is unacceptable. When the "more modern" release flow has features matching hoe and its plugins I'll consider switching. Today it does not have those features. You can get started by adding a patch to bundler to use Gem::PackageTask so the gem can depend on rake |
f05eab5
to
a922fcb
Compare
Updated I'm not interested in learning hoe / reading docs on it, since I'm not trying to use it in the future. This works to add prerequisites to tasks and should work for bundler task(:foo) { puts "FOO" }
task(:bar) { puts "BAR" }
Rake::Task[:foo].prerequisites << :bar |
Providing me with workarounds for a defective tool is not convincing me to use it |
ae95277
to
8ec5327
Compare
it's not a workaround, it's how rake tasks are used 🤷♂ |
alls clean now I hope |
@drbrain good to go ? |
PS: I might know a little about rake tasks and how best to use them as I have been rake maintainer. Bundler is using them incorrectly and I won't consider using it until it's fixed. Stop trying to argue with me on this, it's not endearing. |
I did not know you have a backstory with rake ... I used prerequisites a lot and it was stable so far 🤷♂ |
before: fun errors like this
@drbrain