-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: add firefox support #52
Conversation
so im debating removing the public async waitForAnchorChange(): Promise<void> {
const notificationPromise = this
.notification_resolvables["Page.navigatedWithinDocument"] = deferred();
await notificationPromise;
delete this.notification_resolvables["Page.navigatedWithinDocument"];
} It's not really a 'sought after method' await Sinco.type(..., "new val") // on chromestatus.com, theres an input field that changes the uri
await Sinco.waitForAnchorChange() // essentially waits until url is https://chromestatus.com/features#new%20val But if i go to chromestatus.com, and change the value of the input field in the console manually, the uri doesn't change, but the chrome client does pick up an event for this in the tests Alongside this, if i do the same with a firefox client, the client doesn't pick up any event for this Is there a need for this method? |
…ashland/sinco into issue-#24-add-firefox-support
Fixes #24
Summary
--allow-write
if using firefox. example:deno run --allow-read=$TMPDIR app_test.ts
build
method, to customise the client