Migrated codebase to typescript #33
Conversation
CluEleSsUK
commented
Jul 7, 2022
•
CluEleSsUK
commented
- modified directory structure to separate tests and lib
- migrated codebase to Typescript
- replaced standard linter with eslint
- replaced ava with jest + ts-jest
- fixed a few small bugs along the way
- fixed optimiser tests and stub - fixed a few setTimeout leaks
fixed some broken and incorrect tests
no new features or any API changes per se, but typescript upgrade seemed more than a patch from a risk POV
| }> | ||
|
|
||
| export interface NetworkClient { | ||
| get(round?: number, options?: ClientOptions): Promise<RandomnessBeacon> |
There was a problem hiding this comment.
Should we have the chainhash as an optional param here rather than in the DrandOptions?
| this.controllers.push(controller) | ||
|
|
||
| try { | ||
| const url = `${this.url}/public/${round || 'latest'}${options.noCache ? '?' + Date.now() : ''}` |
There was a problem hiding this comment.
are you handling the chain hash at the url level then?
There was a problem hiding this comment.
I just translated the old impl and curiously it ignores the chainHash and just calls the default public, e.g. https://pl-us.testnet.drand.sh/public/latest.
This needs rethought for sure
There was a problem hiding this comment.
That's because the chainHash endpoint is a new thing brought by the multibeacon support in 2022.
There was a problem hiding this comment.
ahhhh right, that makes sense then. In that case, I will raise a separate PR for that when I implement unchained beacon verification (which I have already basically done in timelock, so I will port it over)
(as per the go client)
coerced some ms to s for a DateTime
