Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: peer gc #918

Merged
merged 2 commits into from
Dec 13, 2021
Merged

fix: peer gc #918

merged 2 commits into from
Dec 13, 2021

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

  • Fix peer gc.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.2 milestone Dec 10, 2021
@gaius-qi gaius-qi self-assigned this Dec 10, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner December 10, 2021 10:35
Signed-off-by: Gaius <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #918 (4ac745c) into main (1e62cc4) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #918      +/-   ##
==========================================
- Coverage   41.44%   41.43%   -0.02%     
==========================================
  Files         106      106              
  Lines        8264     8266       +2     
==========================================
  Hits         3425     3425              
- Misses       4399     4401       +2     
  Partials      440      440              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 41.43% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/supervisor/peer.go 47.90% <0.00%> (-0.37%) ⬇️
client/daemon/peer/peertask_base.go 47.29% <0.00%> (ø)

@yxxhero yxxhero merged commit 869f3d1 into main Dec 13, 2021
@yxxhero yxxhero deleted the feature/status branch December 13, 2021 02:42
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* fix: peer gc

Signed-off-by: Gaius <[email protected]>

* Check whether the peer is in zombie state

Signed-off-by: sunwp <[email protected]>

Co-authored-by: sunwp <[email protected]>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants