Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support create container without docker-compose #915

Merged
merged 1 commit into from
Dec 10, 2021
Merged

feat: support create container without docker-compose #915

merged 1 commit into from
Dec 10, 2021

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Dec 10, 2021

Signed-off-by: Jim Ma [email protected]

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner December 10, 2021 03:39
@jim3ma jim3ma force-pushed the feat/support-create-container-without-docker-compose branch 2 times, most recently from f7f198b to bec912e Compare December 10, 2021 03:48
@jim3ma jim3ma force-pushed the feat/support-create-container-without-docker-compose branch from bec912e to 54f184f Compare December 10, 2021 03:51
gaius-qi
gaius-qi approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma merged commit 5b502aa into main Dec 10, 2021
@jim3ma jim3ma deleted the feat/support-create-container-without-docker-compose branch December 10, 2021 06:24
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
@jim3ma @gaius-qi
feat: support create container without docker-compose (#915)
6b2c4ec 
Signed-off-by: Jim Ma <[email protected]>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
@gaius-qi
fix: when the task has started and did not download the data, gc is f…
59df0b9 
…ailed (dragonflyoss#915)

fix: if the task has started and did not download the data, gc is failed

Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@244372610 244372610 244372610 approved these changes

@gaius-qi gaius-qi gaius-qi approved these changes

@bergwolf bergwolf Awaiting requested review from bergwolf bergwolf is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@yangjun289519474 yangjun289519474 Awaiting requested review from yangjun289519474 yangjun289519474 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jim3ma @gaius-qi @244372610