Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load source plugins #892

Merged
merged 5 commits into from
Dec 8, 2021
Merged

Fix load source plugins #892

merged 5 commits into from
Dec 8, 2021

Conversation

244372610
Copy link
Contributor

Description

Load source plugins

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@244372610 244372610 requested a review from a team as a code owner December 7, 2021 13:56
@codecov-commenter
Copy link

Codecov Report

Merging #892 (acc74f6) into main (809353e) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #892      +/-   ##
==========================================
- Coverage   41.44%   41.42%   -0.03%     
==========================================
  Files         105      105              
  Lines        8222     8226       +4     
==========================================
  Hits         3408     3408              
- Misses       4374     4378       +4     
  Partials      440      440              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 41.42% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/source/source_client.go 1.85% <0.00%> (-0.08%) ⬇️
client/daemon/peer/peertask_base.go 47.27% <0.00%> (ø)

gaius-qi
gaius-qi previously approved these changes Dec 7, 2021
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: sunwp <[email protected]>
Signed-off-by: sunwp <[email protected]>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit f0f4d6c into main Dec 8, 2021
@gaius-qi gaius-qi deleted the feature/loadSourcePlugins branch December 8, 2021 02:35
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
* load source plugins

Signed-off-by: sunwp <[email protected]>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Bumps [blake3](https://github.com/BLAKE3-team/BLAKE3) from 1.5.4 to 1.5.5.
- [Release notes](https://github.com/BLAKE3-team/BLAKE3/releases)
- [Commits](BLAKE3-team/BLAKE3@1.5.4...1.5.5)

---
updated-dependencies:
- dependency-name: blake3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants