Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small size task failed due to digest error #886

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Dec 7, 2021

Signed-off-by: Jim Ma [email protected]

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner December 7, 2021 09:54
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #886 (4972639) into main (361a6bb) will decrease coverage by 0.08%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #886      +/-   ##
==========================================
- Coverage   41.25%   41.16%   -0.09%     
==========================================
  Files         105      105              
  Lines        8254     8254              
==========================================
- Hits         3405     3398       -7     
- Misses       4409     4417       +8     
+ Partials      440      439       -1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 41.16% <50.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_base.go 46.66% <0.00%> (ø)
client/daemon/peer/piece_manager.go 62.28% <100.00%> (ø)
client/daemon/peer/peertask_stream.go 53.82% <0.00%> (-2.15%) ⬇️

@jim3ma jim3ma merged commit 8e6596d into main Dec 7, 2021
@jim3ma jim3ma deleted the fix/small-size-task-digest-error branch December 7, 2021 10:28
gaius-qi pushed a commit that referenced this pull request Dec 7, 2021
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants