Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: dfpath pkg #879

Merged
merged 7 commits into from
Dec 8, 2021
Merged

refactor: dfpath pkg #879

merged 7 commits into from
Dec 8, 2021

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Dec 6, 2021

Description

  • Refactor dfpath pkg.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi added this to the v2.0.2 milestone Dec 6, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner December 6, 2021 10:34
@gaius-qi gaius-qi self-assigned this Dec 6, 2021
Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi force-pushed the feature/dfpath branch 2 times, most recently from e7c5b67 to 329e7fa Compare December 7, 2021 08:22
Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi force-pushed the feature/dfpath branch 4 times, most recently from eb1c696 to ec7cf47 Compare December 7, 2021 14:07
Signed-off-by: Gaius <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #879 (3c49928) into main (f0f4d6c) will increase coverage by 41.39%.
The diff coverage is 44.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #879       +/-   ##
=========================================
+ Coverage      0   41.39%   +41.39%     
=========================================
  Files         0      106      +106     
  Lines         0     8255     +8255     
=========================================
+ Hits          0     3417     +3417     
- Misses        0     4394     +4394     
- Partials      0      444      +444     
Flag Coverage Δ
unittests 41.39% <44.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/config/dfget.go 23.52% <ø> (ø)
client/config/peerhost.go 35.29% <ø> (ø)
client/daemon/daemon.go 5.59% <0.00%> (ø)
manager/config/config.go 0.00% <ø> (ø)
pkg/source/plugin.go 0.00% <0.00%> (ø)
pkg/source/source_client.go 1.98% <0.00%> (ø)
scheduler/config/config.go 4.81% <ø> (ø)
scheduler/core/evaluator/evaluator.go 71.42% <0.00%> (ø)
internal/dfpath/dfpath.go 48.38% <48.38%> (ø)
client/config/dynconfig.go 58.06% <66.66%> (ø)
... and 109 more

@yxxhero yxxhero merged commit ee23dec into main Dec 8, 2021
@yxxhero yxxhero deleted the feature/dfpath branch December 8, 2021 08:16
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: dfpath

Signed-off-by: Gaius <[email protected]>

* feat: dfpath

Signed-off-by: Gaius <[email protected]>

* feat: path

Signed-off-by: Gaius <[email protected]>

* feat: plugin

Signed-off-by: Gaius <[email protected]>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants